Skip to content

Conversation

@jkgoodrich
Copy link
Contributor

The way context_length is currently determined, there needs to be a full scan through the HT/MT. This allows for a parameter to be passed in instead.

It also throws an error if it finds a 'context' value that is not the expected length. And if no parameter is passed it will detect it using the number of specified values in num_scan_context_length.

@jkgoodrich jkgoodrich requested a review from klaricch April 13, 2023 19:27
Copy link
Contributor

@klaricch klaricch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jkgoodrich jkgoodrich merged commit 9a376ed into main Apr 14, 2023
@jkgoodrich jkgoodrich deleted the jg/constraint_context_length_update branch April 14, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants