Avoid DeprecationWarnings from superseded hail function and import [minor] #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite invocations of hl.cond() to hl.if_else(). Also import GoogleStorageAsyncFS from its modern location.
KoalaQin
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite remaining invocations of
hl.cond()tohl.if_else(). There are already numerous instances ofhl.if_else()in gnomad_methods, so this has no compatibility considerations.Also (in gnomad/utils/file_utils.py) import
GoogleStorageAsyncFSfrom its modern location. This has beenhailtop.aiocloud.aiogooglesince hail 2.0.78 (see hail-is/hail#10898 and hail-is/hail#10974). If gnomad_methods needs to be compatible with versions of hail prior to 2.0.78, this part of the change should be omitted.Very minor, but a few of these appear in our test logs which makes for noise when tracking down other problems via the logs.