-
Notifications
You must be signed in to change notification settings - Fork 31
Add coverage_metric param to allow for different metrics of coverage and cov_model_type option to allow for linear or logarithmic #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions. Also, can you update the title to be a little more specific for the change log and add change log labels
Co-authored-by: jkgoodrich <[email protected]>
Co-authored-by: jkgoodrich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just some small wording/formatting changes, and a logger request.
Co-authored-by: jkgoodrich <[email protected]>
Co-authored-by: jkgoodrich <[email protected]>
Co-authored-by: jkgoodrich <[email protected]>
Co-authored-by: jkgoodrich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add in options to set name for coverage metric and cov_model_type