Skip to content

Conversation

klaricch
Copy link
Contributor

Add in options to set name for coverage metric and cov_model_type

Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions. Also, can you update the title to be a little more specific for the change log and add change log labels

@klaricch klaricch changed the title Add coverage metrics and cov_model_type options Add coverage_metric param to allow for different metrics of coverage and cov_model_type option to allow for linear or logarithmic Aug 20, 2024
@klaricch klaricch requested a review from jkgoodrich August 20, 2024 14:41
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just some small wording/formatting changes, and a logger request.

@klaricch klaricch requested a review from jkgoodrich August 21, 2024 18:16
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants