Add browser tables to resources #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkgoodrich
requested changes
Jan 10, 2025
gnomad/resources/grch38/gnomad.py
Outdated
| :return: Path to browser gene Table. | ||
| """ | ||
| return "gs://gnomad-public-requester-pays/resources/grch38/browser/gnomad.genes.GRCh38.GENCODEv39.ht" |
There was a problem hiding this comment.
change if we rename for the repartition
There was a problem hiding this comment.
I added the note here for the current 50 partitions, they haven't been synced yet, we were discussing if 50 is the best now that they have pext data in it. I don't know if it's worth exploring an optimal number of partitions, since we don't use this table for now.
There was a problem hiding this comment.
Okay, I will change this to 100, I found it was faster than 50 with pext data in it, preliminarily.
jkgoodrich
reviewed
Jan 14, 2025
jkgoodrich
approved these changes
Jan 14, 2025
jkgoodrich
requested changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add browser variant and gene tables in gnomad resources. For gene tables, they ran multiple steps of transformation to get the intervals for CDS, UTR and exon.