[...] refactor stand-alone build definitions in android/build.gradle (generated artifact)

templates/android.js

@@ -2,21 +2,27 @@ module.exports = platform => [{
   name: () => `${platform}/build.gradle`,
   content: ({ packageIdentifier }) => `// ${platform}/build.gradle
 
+project.logger.lifecycle('** defining STANDALONE_BUILD_TOOLS_CLASSPATH')
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
+def isStandalone = (project == rootProject)
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
 
 buildscript {
+    project.logger.lifecycle('** starting buildscript for stand-alone')
     // The Android Gradle plugin is only required when opening the android folder stand-alone.
     // This avoids unnecessary downloads and potential conflicts when the library is included as a
     // module dependency in an application project.
-    if (project == rootProject) {
+    if (isStandalone) {
         repositories {
             google()
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/integration/cli/create/view/__snapshots__/cli-create-with-view.test.js.snap

@@ -126,6 +126,8 @@ sdk.dir=/Users/{username}/Library/Android/sdk
     "name": "react-native-integration-view-test-package/android/build.gradle",
     "theContent": "// android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -140,7 +142,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/integration/cli/create/with-defaults/__snapshots__/cli-create-with-defaults.test.js.snap

@@ -126,6 +126,8 @@ sdk.dir=/Users/{username}/Library/Android/sdk
     "name": "react-native-integration-test-package/android/build.gradle",
     "theContent": "// android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -140,7 +142,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-injection/create/view/with-defaults/__snapshots__/create-view-with-defaults.test.js.snap

@@ -201,6 +201,8 @@ content:
 --------
 // android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -215,7 +217,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-injection/create/view/with-example/with-defaults/__snapshots__/create-view-with-example-with-defaults.test.js.snap

@@ -206,6 +206,8 @@ content:
 --------
 // android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -220,7 +222,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-injection/create/view/with-example/with-options/__snapshots__/create-view-with-example-with-options.test.js.snap

@@ -206,6 +206,8 @@ content:
 --------
 // android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -220,7 +222,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-injection/create/view/with-options/for-android/__snapshots__/lib-view-android-config-options.test.js.snap

@@ -163,6 +163,8 @@ content:
 --------
 // android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -177,7 +179,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-injection/create/with-defaults/__snapshots__/create-with-defaults.test.js.snap

@@ -201,6 +201,8 @@ content:
 --------
 // android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -215,7 +217,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-injection/create/with-example/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap

@@ -206,6 +206,8 @@ content:
 --------
 // android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -220,7 +222,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-injection/create/with-example/with-missing-package-scripts/__snapshots__/recover-from-missing-package-scripts.test.js.snap

@@ -206,6 +206,8 @@ content:
 --------
 // android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -220,7 +222,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-injection/create/with-example/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-null-prefix.test.js.snap

@@ -206,6 +206,8 @@ content:
 --------
 // android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -220,7 +222,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-injection/create/with-example/with-options/__snapshots__/create-with-example-with-options.test.js.snap

@@ -206,6 +206,8 @@ content:
 --------
 // android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -220,7 +222,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-injection/create/with-name-in-camel-case/__snapshots__/create-with-name-in-camel-case.test.js.snap

@@ -201,6 +201,8 @@ content:
 --------
 // android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -215,7 +217,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-injection/create/with-options/for-android/__snapshots__/create-with-options-for-android.test.js.snap

@@ -163,6 +163,8 @@ content:
 --------
 // android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -177,7 +179,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-injection/create/with-options/platforms-array/__snapshots__/platforms-array.test.js.snap

@@ -201,6 +201,8 @@ content:
 --------
 // android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -215,7 +217,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-injection/create/with-options/platforms-comma-separated/__snapshots__/platforms-comma-separated.test.js.snap

@@ -201,6 +201,8 @@ content:
 --------
 // android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -215,7 +217,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-injection/create/with-options/with-custom-module-prefix/__snapshots__/create-with-custom-module-prefix.test.js.snap

@@ -201,6 +201,8 @@ content:
 --------
 // android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -215,7 +217,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-injection/create/with-options/with-module-name/__snapshots__/create-with-module-name.test.js.snap

@@ -201,6 +201,8 @@ content:
 --------
 // android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -215,7 +217,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-mocks/cli/command/func/with-options/__snapshots__/cli-command-func-with-options.test.js.snap

@@ -205,6 +205,8 @@ buck-out/
     "outputFileName": "react-native-alice-bobbi/android/build.gradle",
     "theContent": "// android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -219,7 +221,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-mocks/cli/program/with-defaults/for-android/__snapshots__/cli-program-with-defaults-for-android.test.js.snap

@@ -328,6 +328,8 @@ buck-out/
     "outputFileName": "react-native-test-package/android/build.gradle",
     "theContent": "// android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -342,7 +344,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }

tests/with-mocks/lib/create/with-example/with-logging/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap

@@ -270,6 +270,8 @@ buck-out/
     "outputFileName": "react-native-alice-bobbi/android/build.gradle",
     "theContent": "// android/build.gradle
 
+def STANDALONE_BUILD_TOOLS_CLASSPATH = 'com.android.tools.build:gradle:3.4.1'
+
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
@@ -284,7 +286,7 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            classpath(STANDALONE_BUILD_TOOLS_CLASSPATH)
         }
     }
 }