fix Android package identifier description text #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
added 2 commits
September 25, 2019 13:10
… into fix-android-package-id-description
Owner
Author
|
This is a quick fix update. I expect to merge it soon for the sake of consistency with iOS option recently updated in PR #166. |
brody4hire
commented
Sep 25, 2019
brody4hire
commented
Sep 25, 2019
Owner
Author
brody4hire
left a comment
brody4hire
left a comment
There was a problem hiding this comment.
Here are "suggested changes" to clarify that this is a Java package identifier that is used by the Android module.
I did the manual point-and-click work to paste this update into all instances of the description text in doc & JavaScript and into all (5) test updates. "Accepting" all of these changes in a batch is not expected to break the Travis CI build.
tests/integration/cli/noargs/__snapshots__/cli-noargs.test.js.snap
Outdated
Show resolved
Hide resolved
tests/with-injection/cli/command/object/__snapshots__/lib-cli-command-object-text.test.js.snap
Outdated
Show resolved
Hide resolved
...m/with-defaults/for-android/__snapshots__/cli-program-with-defaults-for-android.test.js.snap
Outdated
Show resolved
Hide resolved
...mocks/cli/program/with-missing-args/__snapshots__/cli-program-with-missing-args.test.js.snap
Outdated
Show resolved
Hide resolved
…ckage identifier that is _used_ by the Android module
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a quick fix, now wanted for the sake of improved consistency with iOS option updated in PR #166
with some TODO items:
update existing test snapshots