login password buttons order

[532910]

Even though these buttons are well readable I always confuse them, as the common order is login:password.

[erayd]

Fair. I have no particular preference.

@maximbaz, do you have an opinion on this one?

Something to consider is that if we change it, we will be conflicting with users' existing muscle memory, which may potentially result in them pasting a password somewhere a username ought to be (and thus having their password end up in logs). This risk is likely small, but not nil.

[532910]

pasting a password somewhere a username ought to be

it always be visible in this case

having their password end up in logs

it's possible only after sending the form, just filling it is not enough

[erayd]

it's possible only after sending the form, just filling it is not enough

That is incorrect; some sites proactively send the username field before submission (especially in signup forms, which often do so to check availability). That said, my point here was muscle memory, which will often result in the form being submitted before the user realises something is wrong, even if the mistake is visible.

[max-baz]

I think this is not the first time this request comes up, I would be okay swapping the buttons.

I think muscle memory risk is not nil but acceptable, given us making the UI more intuitive.

[erayd]

OK. Let's swap them.

[max-baz]

Was fixed by #229, will be part of the next release 👍