Handle inability to inject script to all frames #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
When does this start counting from? If a page is slow to load, will it cause problems? |
Member
Author
|
It starts counting since the moment you tell Browserpass to fill a form for you, I think in vast majority of cases the page is already loaded when users attempt to fill a form. |
Member
Author
|
By the way, this is another review that is easier to review with whitespace diff off. |
erayd
requested changes
Apr 19, 2019
src/background.js
Outdated
| const MAX_WAIT = 1000; | ||
|
|
||
| return new Promise(async (resolve, reject) => { | ||
| setTimeout(reject, MAX_WAIT); |
Collaborator
There was a problem hiding this comment.
This looks problematic. On success, it will both reject and resolve, which is probably an error.
src/background.js
Outdated
| try { | ||
| await injectScript(settings, true); | ||
| injectedAllFrames = true; | ||
| } catch {} |
Collaborator
There was a problem hiding this comment.
Can you please put an explicit noop comment here. Error suppression with no action should have an explaining comment, both to clarify why, and to prevent one of us accidentally attempting to do something with the error later.
erayd
approved these changes
Apr 19, 2019
fkneist
pushed a commit
to fkneist/browserpass-extension
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium can hang indefinitely trying to inject a script to certain kinds of iframes, such as the one present on
ox.credativ.com(#62 (comment)). The workaround is to wait at most 1 second, and then abort the injection.Hopefully
1 secis more than enough for normal cases and we won't mess with anybody's Browserpass, if we see user reports about "Error: Unable to inject script in the top frame", we must increase this timeout.