Skip to content

Clear credentials from clipboard after 60 seconds #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2019
Merged

Clear credentials from clipboard after 60 seconds #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,17 +139,17 @@ If you want to intentionally disable phishing attack protection and search the e

Note: If the cursor is located in the search input field, every shortcut that works on the selected entry will be applied on the first entry in the popup list.

| Shortcut | Action |
| ---------------------------------------------------- | ------------------------------------------------ |
| <kbd>Ctrl+Shift+L</kbd> | Open Browserpass popup |
| <kbd>Ctrl+Shift+F</kbd> | Fill the form with the best matching credentials |
| <kbd>Enter</kbd> | Submit form with currently selected credentials |
| Arrow keys and <kbd>Tab</kbd> / <kbd>Shift+Tab</kbd> | Navigate popup list |
| <kbd>Ctrl+C</kbd> | Copy password to clipboard |
| <kbd>Ctrl+Shift+C</kbd> | Copy username to clipboard |
| <kbd>Ctrl+G</kbd> | Open URL in the current tab |
| <kbd>Ctrl+Shift+G</kbd> | Open URL in the new tab |
| <kbd>Backspace</kbd> (with no search text entered) | Search passwords in the entire password store |
| Shortcut | Action |
| ---------------------------------------------------- | ----------------------------------------------------- |
| <kbd>Ctrl+Shift+L</kbd> | Open Browserpass popup |
| <kbd>Ctrl+Shift+F</kbd> | Fill the form with the best matching credentials |
| <kbd>Enter</kbd> | Submit form with currently selected credentials |
| Arrow keys and <kbd>Tab</kbd> / <kbd>Shift+Tab</kbd> | Navigate popup list |
| <kbd>Ctrl+C</kbd> | Copy password to clipboard (will clear in 60 seconds) |
| <kbd>Ctrl+Shift+C</kbd> | Copy username to clipboard (will clear in 60 seconds) |
| <kbd>Ctrl+G</kbd> | Open URL in the current tab |
| <kbd>Ctrl+Shift+G</kbd> | Open URL in the new tab |
| <kbd>Backspace</kbd> (with no search text entered) | Search passwords in the entire password store |

### Password matching and sorting

Expand Down Expand Up @@ -271,7 +271,9 @@ Browserpass extension requests the following permissions:
| -------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `debugger` | Only used for "auto-submit" functionality: if all attepts to locate a "Submit" button failed, Browserpass will put focus inside the login form and issue an <kbd>Enter</kbd> keypress. This is only available in Chromium-based browsers, and sadly this permission [cannot be specified as optional](https://developer.chrome.com/apps/permissions) |
| `activeTab` | To get URL of the current tab, used for example to determine which passwords to show you by default in the popup |
| `alarms` | To set a timer for clearing the clipboard 60 seconds after credentials are copied |
| `tabs` | To get URL of a given tab, used for example to set count of the matching passwords for a given tab |
| `clipboardRead` | To ensure only copied credentials and not other content is cleared from the clipboard after 60 seconds |
| `clipboardWrite` | For "Copy password" and "Copy username" functionality |
| `nativeMessaging` | To allow communication with the native app |
| `notifications` | To show browser notifications on install or update |
Expand Down
46 changes: 43 additions & 3 deletions src/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ var defaultSettings = {

var authListeners = {};

// the last text copied to the clipboard is stored here in order to be cleared after 60 seconds
let lastCopiedText = null;

chrome.browserAction.setBadgeBackgroundColor({
color: "#666"
});
Expand Down Expand Up @@ -80,6 +83,16 @@ chrome.commands.onCommand.addListener(async command => {
}
});

// handle fired alarms
chrome.alarms.onAlarm.addListener(alarm => {
if (alarm.name === "clearClipboard") {
if (readFromClipboard() === lastCopiedText) {
copyToClipboard("", false);
}
lastCopiedText = null;
}
});

chrome.runtime.onInstalled.addListener(onExtensionInstalled);

//----------------------------------- Function definitions ----------------------------------//
Expand Down Expand Up @@ -127,14 +140,15 @@ async function updateMatchingPasswordsCount(tabId) {
}

/**
* Copy text to clipboard
* Copy text to clipboard and optionally clear it from the clipboard after one minute
*
* @since 3.0.0
* @since 3.2.0
*
* @param string text Text to copy
* @param boolean clear Whether to clear the clipboard after one minute
* @return void
*/
function copyToClipboard(text) {
function copyToClipboard(text, clear = true) {
document.addEventListener(
"copy",
function(e) {
Expand All @@ -144,6 +158,31 @@ function copyToClipboard(text) {
{ once: true }
);
document.execCommand("copy");

if (clear) {
lastCopiedText = text;
chrome.alarms.create("clearClipboard", { delayInMinutes: 1 });
}
}

/**
* Read plain text from clipboard
*
* @since 3.2.0
*
* @return string The current plaintext content of the clipboard
*/
function readFromClipboard() {
const ta = document.createElement("textarea");
// these lines are carefully crafted to make paste work in both Chrome and Firefox
ta.contentEditable = true;
ta.textContent = "";
document.body.appendChild(ta);
ta.select();
document.execCommand("paste");
const content = ta.value;
document.body.removeChild(ta);
return content;
}

/**
Expand Down Expand Up @@ -1069,6 +1108,7 @@ function onExtensionInstalled(details) {
}
} else if (details.reason === "update") {
var changelog = {
3002000: "New permissions added to clear copied credentials after 60 seconds.",
3000000:
"New major update is out, please update the native host app to v3.\n" +
"Instructions here: https://github.com/browserpass/browserpass-native"
Expand Down
2 changes: 2 additions & 0 deletions src/manifest-chromium.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
"permissions": [
"debugger",
"activeTab",
"alarms",
"tabs",
"clipboardRead",
"clipboardWrite",
"nativeMessaging",
"notifications",
Expand Down
2 changes: 2 additions & 0 deletions src/manifest-firefox.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@
},
"permissions": [
"activeTab",
"alarms",
"tabs",
"clipboardRead",
"clipboardWrite",
"nativeMessaging",
"notifications",
Expand Down