Add option to ignore entries matching a pattern #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-baz
approved these changes
Aug 31, 2019
Member
max-baz
left a comment
max-baz
left a comment
There was a problem hiding this comment.
Minor comments, otherwise looks quite good!
fkneist
pushed a commit
to fkneist/browserpass-extension
that referenced
this pull request
Feb 12, 2022
* Add option to ignore entries matching a pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds an
ignoreoption tobrowserpass.json. This takes either a string or an array of strings, with each string being a pattern using the standard.gitignoresyntax. All matching files will be completely ignored by Browserpass.Why
Because I have a fair amount of stuff stored in my pass repo which shows up by default in Browserpass, but really shouldn't (e.g. SSH passwords, HTTPS certificates, decryption passwords for associated keys, etc).