Avoid live-updating badgeCache object #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Merging as I feel confident this is what you had in mind, if you have comments, do leave them 😉 |
erayd
reviewed
Sep 27, 2019
| badgeCache = { | ||
| files: response.data.files, | ||
| settings: settings, | ||
| expires: Date.now() + 60 * 1000, |
Collaborator
There was a problem hiding this comment.
Please don't use magic numbers.
|
|
||
| if (badgeCache.files === null) { | ||
| return; // badge cache refresh in progress | ||
| if (badgeCache.isRefreshing) { |
Collaborator
There was a problem hiding this comment.
Doesn't this condition belong at the very beginning of the function?
Member
Author
There was a problem hiding this comment.
You are right, it does, remnants of the previous logic 👍
fkneist
pushed a commit
to fkneist/browserpass-extension
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing comments in #173