Allow data: scheme for images in CSP
#185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://stackoverflow.com/a/18449556 it seems we need to whitelist
data:scheme.This bug appeared because light theme PR for the first time introduced select box in the options screen, and browser styles arrow in the select box using an image constructed with
data:.I think there's no harm security-wise in allowing
data:scheme, what do you think?Fixes #184