Fix SVG icon in Firefox without allowing insecure CSS #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erayd
approved these changes
Feb 2, 2020
Collaborator
erayd
left a comment
erayd
left a comment
There was a problem hiding this comment.
I'm not great with SVG styling. Provided it works reliably, I'm OK with this. Note that I've not actually tested this, only looked at the code change.
Member
Author
|
I can observe a minor difference in Chrome, but I think both old and new way look equally fine. The icon in Firefox looks colorful, so it's good. Feel free to ping me later if you find that it doesn't look reliable and we will revisit this. |
fkneist
pushed a commit
to fkneist/browserpass-extension
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All that inline style is useless and can be replaced with just a couple of standard SVG attributes.
Properly fixes #190