Add hotkeys to tooltips #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-baz
approved these changes
Jun 3, 2020
src/popup/interface.js
Outdated
| m("div.action.copy-user", { | ||
| tabindex: 0, | ||
| title: "Copy username", | ||
| title: "Copy username | <CTRL+SHIFT+C>", |
Member
There was a problem hiding this comment.
Awesome idea, love it! I would prefer a capitalized way of writing shortcuts, e.g. <Ctrl+Shift+C> instead of <CTRL+SHIFT+C>, this way it doesn't stand out as much... 🙂
fkneist
pushed a commit
to fkneist/browserpass-extension
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add hotkey hints to tooltips in the popup interface.
Why
Makes hotkey discoverability easier for users.