Allow hiding badge counter #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@maximbaz Do you need me to do performance testing on this, or have you verified that bit already and just need code review? |
Member
Author
|
Performance test would be appreciated, no I don't know for sure that it solves #224 |
Collaborator
|
Sweet, I'll test that aspect first then. |
erayd
added
feature request
Closed
Member
Author
|
This is very requested feature recently, and multiple people have tested this PR. I've just rebased it on latest |
Member
Author
|
I'm going to include this in the upcoming release, hope that's okay :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this implementation doesn't just prevent entering
updateMatchingPasswordsCount()function (as I personally initially expected), but only prevents doing what is hopefully the most expensive computation: getting a huge array of files and processing them.This way, when a user toggles badge option we would refresh the badge instantly, and also if a user puts
hideBadgein their.browserpass.jsonwe would detect it within a minute. This also means that tab update handler still executes and it still refreshes settings every minute.I would be really interested to know if this solves #224, @elprans if you could try this PR it would be much appreciated.
@erayd what do you think in general?
Fixes #224
Fixes #103
Fixes #342
Fixes #348