Skip to content

Allow empty login #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2020
Merged

Allow empty login #232

merged 1 commit into from
Dec 31, 2020

Conversation

@erayd
Copy link
Collaborator

@erayd erayd commented Sep 11, 2020

What

  • Allow the login field to be empty.

Why

@erayd erayd added the bugfix Fixes something that doesn't work correctly. label Sep 11, 2020
@erayd erayd requested a review from max-baz September 11, 2020 05:31
@erayd erayd self-assigned this Sep 11, 2020
@kitt-cat
Copy link

kitt-cat commented Dec 31, 2020

Thanks for implementing this! Who needs to check it off? @maximbaz?

@erayd
Copy link
Collaborator Author

erayd commented Dec 31, 2020

Thanks for implementing this! Who needs to check it off? @maximbaz?

Most welcome. And yes, just waiting on @maximbaz for code review.

max-baz
max-baz approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@max-baz max-baz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, apologies for the long delay, this PR has completely slipped off my radar 🙂

@erayd erayd merged commit d2d2468 into browserpass:master Dec 31, 2020
@erayd erayd deleted the empty-login branch December 31, 2020 12:51
@erayd erayd mentioned this pull request May 18, 2021
Closed
fkneist pushed a commit to fkneist/browserpass-extension that referenced this pull request Feb 12, 2022
@erayd
Allow empty login (browserpass#232)
ff39b42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-baz max-baz max-baz approved these changes

Assignees

@erayd erayd

Labels

bugfix Fixes something that doesn't work correctly.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erayd @kitt-cat @max-baz