Skip to content

Conversation

@max-baz
Copy link
Member

@max-baz max-baz commented Apr 9, 2019

@erayd, @DamienCassou anything else you want to see mentioned, or this short summary is enough?

Fixes #79

Copy link
Collaborator

@erayd erayd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-). Do you think it's worth mentioning why we don't fill user / pass when openid: is present, or do you consider that unnecessary?

@DamienCassou
Copy link

DamienCassou commented Apr 9, 2019

Looks good :-). Do you think it's worth mentioning why we don't fill user / pass when openid: is present, or do you consider that unnecessary?

The current phrasing might be understood as a limitation of browserpass. I think a different phrasing might bring some clarity and answer your concern. Something like:

When an openid: field is defined in a password entry and an openid form field is found in the current page, then Browserpass will fill the OpenID field in a form. In this case, Browserpass will not attempt to fill username and password even if they are present in the password entry because logging in with OpenID does not require them.

@max-baz
Copy link
Member Author

max-baz commented Apr 9, 2019

Thanks guys, I added clarification 👍

@max-baz max-baz merged commit 71291e6 into browserpass:master Apr 9, 2019
max-baz added a commit that referenced this pull request Apr 9, 2019
fkneist pushed a commit to fkneist/browserpass-extension that referenced this pull request Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants