Bug 1446236 - search-google.html.tmpl: Calculate sitesearch from urlbase #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanwh
changed the title
dylanwh
requested changes
Mar 16, 2018
|
|
||
| <form method="get" action="https://www.google.com/search"> | ||
| <input type="hidden" name="sitesearch" value="bugzilla.mozilla.org"> | ||
| <input type="hidden" name="sitesearch" value="[% urlbase.match('^([^:]*://)?(.*?)/?$').1 %]"> |
There was a problem hiding this comment.
With the stuff in #25 you can just write [% urlbase.host FILTER html %]
There was a problem hiding this comment.
What about the case when Bugzilla is not installed at the domain root?
There was a problem hiding this comment.
Aha! Perhaps... urlbase.host _ urlbase.path?
I'm not sure if sitesearch takes path though.
There was a problem hiding this comment.
Fairly sure it does, we've been using it for https://dlang.org/phobos/ for a while. Trailing slash is optional, not sure if it should be removed (for aesthetic reasons & to preserve behaviour identical to before the change)?
dylanwh
approved these changes
Apr 8, 2018
dylanwh
pushed a commit
that referenced
this pull request
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a hard-coded BMO reference.