Improve scrolling behaviour for VariableSizeList with align='center' #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… will calculate a more accurate offset for variable size lists
nathan-knight
commented
Jun 10, 2021
| Object { | ||
| "overscanStartIndex": 0, | ||
| "overscanStopIndex": 6, | ||
| "overscanStopIndex": 5, |
Author
There was a problem hiding this comment.
It now scrolls to the exact edges instead of slightly offset so there aren't partially visible items anymore which is why these indices shifted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original behaviour computed the average of the minimum and maximum offsets which worked for centering on items in the middle but would not produce the nearest offset to centered for items at the extreme ends of the list.
This is similar to part of #274 which only changed the calculation for FixedSizeList.