shared heap: fix some issues and add basic testcase #3801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenLY1
force-pushed
the
shared_heap_dev
branch
from
5ff2637 to
5f933d7
Compare
wenyongh
reviewed
Sep 19, 2024
core/iwasm/common/wasm_memory.c
Outdated
| if (!(heap = runtime_malloc(heap_struct_size, error_buf, error_buf_size))) { | ||
| goto fail1; | ||
| } | ||
| heap->size = size; |
Contributor
There was a problem hiding this comment.
The size is changed later with size = align_uint(size, os_getpagesize()), had better set heap->size after that, e.g. after L202
core/iwasm/include/wasm_export.h
Outdated
| WASM_LOG_LEVEL_VERBOSE = 4 | ||
| } log_level_t; | ||
|
|
||
| #if WASM_ENABLE_SHARED_HEAP != 0 |
Contributor
There was a problem hiding this comment.
Could you remove this macro control in this file? Including L2122. No need to add macro here, since developer may just use this header file and the compiled wamr runtime lib (libvmlib.a or libiwasm.so), adding the control may lead to compilation error in his project.
WenLY1
force-pushed
the
shared_heap_dev
branch
from
5f933d7 to
2387429
Compare
wenyongh
approved these changes
Sep 19, 2024
WenLY1
force-pushed
the
shared_heap_dev
branch
4 times, most recently
from
f8d1af9 to
f231061
Compare
WenLY1
changed the title
Signed-off-by: wenlingyun1 <[email protected]>
Signed-off-by: wenlingyun1 <[email protected]>
Signed-off-by: wenlingyun1 <[email protected]>
Signed-off-by: wenlingyun1 <[email protected]>
WenLY1
force-pushed
the
shared_heap_dev
branch
from
6f636c4 to
f05dc75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.