Skip to content

Add a CLI option to specify shared heap size on Windows platform #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

Add a CLI option to specify shared heap size on Windows platform #4503

merged 1 commit into from
Jul 22, 2025

Conversation

kylo5aby
Copy link
Contributor

No description provided.

@kylo5aby
Copy link
Contributor Author

Since #4499 already implemented posix part, this pr only retains the win plateform part

@kylo5aby kylo5aby changed the title Add a CL option to specify shared heap size Add a CLI option to specify shared heap size Jul 18, 2025
@kylo5aby kylo5aby changed the title Add a CLI option to specify shared heap size Add a CLI option to specify shared heap size on Windows platform Jul 18, 2025
@lum1n0us lum1n0us added the enhancement Check if this issue/PR enhances a feature; scripts will use this info. label Jul 21, 2025
loganek
loganek approved these changes Jul 22, 2025
View reviewed changes
Copy link
Collaborator

@loganek loganek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just wanted to note that there's a lot of repetition between windows and posix main.c file (not only about shared heap). We might need to refactor the code so the code is reused across both platforms.

@loganek loganek merged commit c080aa8 into bytecodealliance:main Jul 22, 2025
451 checks passed
@kylo5aby kylo5aby deleted the shared-heap-cl branch July 24, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loganek loganek loganek approved these changes

@lum1n0us lum1n0us lum1n0us approved these changes

@TianlongLiang TianlongLiang TianlongLiang approved these changes

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

@wenyongh wenyongh Awaiting requested review from wenyongh wenyongh is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

@yamt yamt Awaiting requested review from yamt yamt is a code owner

Assignees
No one assigned
Labels
enhancement Check if this issue/PR enhances a feature; scripts will use this info.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kylo5aby @loganek @lum1n0us @TianlongLiang