Fix generated bindings for list-of-borrows #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue for imported functions taking `list<borrow<T>>` arguments. Previously they were erroneously passed through as lists-of-pointers and now they're correctly mapped to list-of-handle-indexes in the ABI. This required rejiggering a bit how types are generated and what's considered owned when, namely requiring that all own handles use `Vec<T>` at the boundary since they need to take ownership.
|
I'll note that testing-wise the existing codegen tests cover a good deal, and otherwise tests for resources are not present at the moment as this requires wasmtime support which is still nascent. |
sunfishcode
reviewed
Sep 18, 2023
sunfishcode
approved these changes
Sep 18, 2023
|
I tested this by copying the bindings generated with this patch into bytecodealliance/wasmtime#7029 and it fixes the bug I was seeing. |
sunfishcode
added a commit
to sunfishcode/wit-abi-up-to-date
that referenced
this pull request
Sep 29, 2023
In particular, this has bytecodealliance/wit-bindgen#670, which fixes a bug hit by `poll-list`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue for imported functions taking
list<borrow<T>>arguments. Previously they were erroneously passed through as lists-of-pointers and now they're correctly mapped to list-of-handle-indexes in the ABI. This required rejiggering a bit how types are generated and what's considered owned when, namely requiring that all own handles useVec<T>at the boundary since they need to take ownership.