Make demo pretty #14
Open
Make demo pretty #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver ther script is run...
Author
|
Sebastian recommended we merge the API first and then look at the speedup after. |
se-jaeger
reviewed
Nov 20, 2025
se-jaeger
reviewed
Nov 20, 2025
se-jaeger
reviewed
Nov 20, 2025
se-jaeger
reviewed
Nov 20, 2025
se-jaeger
reviewed
Nov 20, 2025
Member
se-jaeger
left a comment
se-jaeger
left a comment
There was a problem hiding this comment.
thanks for your work on this. I left some comments here, rest of my feedback will be delivered offline.
Author
|
I believe all the prior comments are addressed. This first draft of the API looks good from my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have basically added a first version of the API, created a demo notebook, and added an interface (
model/synthesizer.py) where users can add arbitrary models for generation.