Skip to content

Conversation

@jirihnidek
Copy link
Collaborator

@jirihnidek jirihnidek commented May 11, 2022

@jirihnidek
Copy link
Collaborator Author

/packit build

@packit-as-a-service
Copy link

No config file for packit (e.g. .packit.yaml) found in candlepin/python-iniparse on commit 9cb34c2

For more info, please check out the documentation: https://packit.dev/docs/packit-service or contact us - Packit team

@jirihnidek jirihnidek force-pushed the jhnidek/fix_readfp branch from 9cb34c2 to 29f5a8a Compare May 11, 2022 12:46
@ptoscano
Copy link
Contributor

Sounds good to me.

One small thing I'd change is in the commit message: if you replace

* Issue: https://github.com/candlepin/python-iniparse/issues/23

with e.g.

Closes #nnn

(or Resolves, or Fixes) then the merging of the commit will automatically close the referenced issue.

* Fixes: #23
* BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2019017
* Replaced few deprecated methods with new methods
@jirihnidek jirihnidek force-pushed the jhnidek/fix_readfp branch from 29f5a8a to d9a083b Compare May 12, 2022 10:56
@jirihnidek
Copy link
Collaborator Author

Sounds good to me.

One small thing I'd change is in the commit message: if you replace

* Issue: https://github.com/candlepin/python-iniparse/issues/23

with e.g.

Closes #nnn

(or Resolves, or Fixes) then the merging of the commit will automatically close the referenced issue.

Fixed

Copy link
Contributor

@ptoscano ptoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace deprecated ConfigParser readfp and unittest aliases for Python 3.12

3 participants