Add Moodle 4.5 (405) support #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fragonite LGTM. Please create an issue for the upstream repo + MR to that repo. Good to merge here after that. |
The hook fix is only necessary due to one of our customisations: #1 Do you want to open a PR for all our changes? |
|
Is there issue/PR for that customisation? |
|
Just this issue, no PR submitted. roelmann#34 |
|
Can you please raise an issue + submit PR which would include your patch as well? |
|
Issue and PR have been created. There actually is an existing upstream PR for #1 (see below). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Requires the
before_http_headershook.The hook calls the original function for backwards compatibility with 4.1.
Testing
Install the plugin.
Add an instance of the block to a course with teachers.
Edit the block settings to show contact information for all teacher roles.
Verify it works correctly.
There is also an admin settings page for the plugin where defaults can be set.