Skip to content

Layer improvement for container and develop container #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 13, 2023

Conversation

FedericoMulas
Copy link
Contributor

@FedericoMulas FedericoMulas commented Aug 2, 2023

Started as a fix for the container, ended up as introducing a develop container.

what is changed:

  • Added additional unused files to .dockerignore
  • Few fix to the container and improved layer stacking. With the change code changes will not trigger the apt installation again but will only copy over the new files.
  • Added Docker build example with parameters to docs/docker.md
  • Added debug state in the Dockerfile definition. This allow to use the container for development/debugging reusing the main container. It leverage the new wptagent_debug.py
  • Partial changes from Fix Markdown in docker.md #625
  • Added possibility to pass parameters to the container instead of using environment variables in docs/docker.md. Ideally we don't really need all the additional environment variable with this change, but I did not removed them for backward compatiblity.
  • Added examples for the new docker stage into the docs/docker.md

what is new:

  • Added .gitattributes to avoid having to fix line endings on sh files on windows.
  • Added wptagent_debug.py for starting the agent in debug mode (useful for the debug container).Foundation/wptagent/compare/master...FedericoMulas:wptagent:docker-debug#diff-ae5611658dcd443d7a30575bebcdf15a71b7a0f5abebb18b62d00aa0373cae74) to explain better the changes.

@FedericoMulas
Copy link
Contributor Author

what is changed:

  • Added Docker build example with parameters to docs/docker.md
    what is new:
  • Added .gitattributes to avoid having to fix line endings on sh files on windows.

@mjkozicki mjkozicki merged commit b29b689 into catchpoint:master Sep 13, 2023
@FedericoMulas FedericoMulas deleted the docker-debug branch September 22, 2023 08:01
@FedericoMulas FedericoMulas restored the docker-debug branch September 22, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants