-
Notifications
You must be signed in to change notification settings - Fork 141
Add trusted mouseClick command to WPT #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging @mjkozicki , @claud-io , would appreciate if you could review this PR and provide feedback. This should be a useful command to run true interactivity tests with Event timing metrics. |
@pmeenan / @vibaldem FYI, this PR is for catchpoint/WebPageTest#3048 and catchpoint/WebPageTest#3049 . |
@pmeenan, please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (though I don't have merge permission)
@mjkozicki would appreciate if you could review this PR and provide feedback; this is to address catchpoint/WebPageTest#3048 and catchpoint/WebPageTest#3049 . |
@claud-io / @lbartoli79 can you review this PR, it's been pending for 5 months 😮 Thanks! |
@jspurlin will try to schedule this for the upcoming weeks |
When will this PR be merged? |
@MaryamHuntsperger Going to merge agent now, but some adjustments to UI are needed for this to work. Documentation must be updated too. |
Existing click and clickAndWait WPT commands are JavaScript initiated events which are synthetic. Hence "Trusted" flag for JS events is set to false. Such events get ignored by EventTiming API (https://www.w3.org/TR/event-timing/). This problem was issued catchpoint/WebPageTest#3048
Moreover, WPT click command does not support right and double click; mentioned in catchpoint/WebPageTest#3049 .
We have created a new mouseClick command with the following format which supports left, right and double click:
mouseClick [tab] Id| selector [tab] left|right|double
The new command uses Devtools Protocol (https://chromedevtools.github.io/devtools-protocol/tot/Input/) input domain to dispatch Trusted mousepressed and mousereleased events.