Skip to content

Conversation

GFM-tt
Copy link

@GFM-tt GFM-tt commented Aug 16, 2019

I added the "allow_ilm_indices" option as documented in https://www.elastic.co/guide/en/elasticsearch/client/curator/current/option_allow_ilm.html

It allows curator to handle Indices which are taged with the ILM flag.
In version 6.8 of ELK there is still a bug that tags Indices with the ILM flag, even if its disabled by default in the Elastic output plugin.

The setting was tested with puppet in our env.
And works like a charm.

@GFM-tt
Copy link
Author

GFM-tt commented Aug 16, 2019

Can someone tell me why the Travis CI failed?
thx

@faxm0dem
Copy link
Member

faxm0dem commented Sep 3, 2019

Hi @GFM-tt, this repo is a fork from an archived module.
We at ccin2p3 only use it internally, but don't support it officially (yet).
The travis build fail because they run against obsolete puppet and ruby versions.
I might fix them in the future.

I can accept your PR, but I'm not sure this will benefit anyone except you and us ;)

@faxm0dem
Copy link
Member

faxm0dem commented Sep 3, 2019

If you'd like this included into our fork, I'd simply ask you to fix the typos (I'll happily link them for you if needed)

@GFM-tt
Copy link
Author

GFM-tt commented Jul 13, 2020

Hi @faxm0dem I actually didn't expected an answer :D

So sorry for the long waiting time.
It would be nice if you could point out those typos to me. There allways my kryptonite :D

Copy link
Member

@faxm0dem faxm0dem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just fix the 3 typos please

# Default: 'False'
#
# [*allow_ilm_indices*]
# Boolean. If allow_ilm_indices is set to True, Curator will ingonre all ILM taged Indices and querry them regardless of ILM Polices.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos:

  • ignore
  • tagged
  • query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants