Skip to content

Nbansal/feedbackchanges #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 10, 2019
Merged

Nbansal/feedbackchanges #30

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6554751
resolve review comments.
Oct 10, 2019
fb31932
Merge remote-tracking branch 'origin/connectedMode' into yuxyao-conne…
Oct 10, 2019
6099569
Fix some indention issue.
Oct 10, 2019
eac8de6
Fix the max-width of banner.
Oct 10, 2019
d781dca
Merge branch 'connectedMode' of https://github.com/cdifino/selenium-i…
nbansal1993 Oct 10, 2019
65e43ba
updating the api documentation
nbansal1993 Oct 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions docs/api/plugins/system.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,21 +64,10 @@ Loads a project into the IDE, as if the user opened it, if the user has unsaved
```
### `POST /control`

Start a connection with a specific connection Id from another chrome extension. When this connection is accepted by the user, Selenium IDE restarts and registers the caller, and the extension takes exclusive control of Selenium IDE until user closes Selenium IDE or another connection is accepted. When this mode is on, the save to computer functionality gets overritten by sending the side file to the extension controlling Selenium IDE. When in this mode, the user needs to add connectionId variable to make other API calls such as `POST /project`, `GET /project`, `POST /log`, `POST /register`.
Start a connection from another chrome extension. When this connection is accepted by the user, Selenium IDE restarts and registers the caller, and the extension takes exclusive control of Selenium IDE until user closes Selenium IDE or another connection is accepted. When this mode is on, the save to computer functionality gets overwritten by sending the side file to the extension controlling Selenium IDE.

The payload of this call is the same manifesto used to register a plugin, in addition to the connection Id, which states the instance of the connection.
The payload of this call is identical to the payload of `POST /register` call.

### `POST /close`

Closes Selenium IDE.

### `POST /connect`

Internal API call only. Used to make all modifications to Selenium IDE when establishing a connection.

```js
{
controlled: true,
controller: JSON plugin manifesto with connection Id
}
```
When Selenium IDE is controlled by another chrome extension, the controller extension can use this API to close the IDE window. If user have any unsaved changes, it will prompt user to whether give up the changes or ignore the close. No payload is needed.