Skip to content

merge last version of V3 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2019
Merged

merge last version of V3 #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0216d99
Updated document to use goog:chromeOptions (#757)
rahull Jul 29, 2019
848d040
Bug fix: Foreach command in selenium-side-runner (#752)
cdifino Aug 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/introduction/command-line-runner.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,13 @@ The runner will automatically set the number of workers to the same number of CP
If you have Chrome installed in a non-standard location on your machine you can specify the path so ChromeDriver knows where to look.

```sh
selenium-side-runner -c "chromeOptions.binary='/path/to/non-standard/Chrome/install'"
selenium-side-runner -c "goog:chromeOptions.binary='/path/to/non-standard/Chrome/install'"
```

With Chrome specific capabilities you can also run the tests headlessly.

```sh
selenium-side-runner -c "chromeOptions.args=[disable-infobars, headless]"
selenium-side-runner -c "goog:chromeOptions.args=[disable-infobars, headless]"
```

## A framework at your fingertips
Expand Down
2 changes: 1 addition & 1 deletion packages/selianize/__tests__/command.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,7 +1163,7 @@ describe('command code emitter', () => {
value: 'iterator',
}
return expect(CommandEmitter.emit(command)).resolves.toBe(
`for (let i = 0; i < vars["collection"].length - 1; i++) {vars["iterator"] = vars["collection"][i];`
`for (let i = 0; i < vars["collection"].length; i++) {vars["iterator"] = vars["collection"][i];`
)
})
it('should emit `assert` command', () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/selianize/src/command.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Licensed to the Software Freedom Conservancy (SFC) under one
// Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
Expand Down Expand Up @@ -802,7 +802,7 @@ function emitControlFlowWhile(target) {

function emitControlFlowForEach(collectionVarName, iteratorVarName) {
return Promise.resolve(
`for (let i = 0; i < vars["${collectionVarName}"].length - 1; i++) {vars["${iteratorVarName}"] = vars["${collectionVarName}"][i];`
`for (let i = 0; i < vars["${collectionVarName}"].length; i++) {vars["${iteratorVarName}"] = vars["${collectionVarName}"][i];`
)
}

Expand Down
4 changes: 0 additions & 4 deletions packages/selianize/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,10 +1127,6 @@ js-levenshtein@^1.1.3:
resolved "https://registry.yarnpkg.com/js-levenshtein/-/js-levenshtein-1.1.6.tgz#c6cee58eb3550372df8deb85fad5ce66ce01d59d"
integrity sha512-X2BB11YZtrRqY4EnQcLX5Rh373zbK4alC1FW7D7MBhL2gtcC17cTnr6DmfHZeS0s2rTHjUTMMHfG7gO8SSdw+g==

js-string-escape@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/js-string-escape/-/js-string-escape-1.0.1.tgz#e2625badbc0d67c7533e9edc1068c587ae4137ef"

"js-tokens@^3.0.0 || ^4.0.0", js-tokens@^4.0.0:
version "4.0.0"
resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-4.0.0.tgz#19203fb59991df98e3a287050d4647cdeaf32499"
Expand Down
5 changes: 0 additions & 5 deletions packages/side-utils/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1327,11 +1327,6 @@ js-levenshtein@^1.1.3:
resolved "https://registry.yarnpkg.com/js-levenshtein/-/js-levenshtein-1.1.6.tgz#c6cee58eb3550372df8deb85fad5ce66ce01d59d"
integrity sha512-X2BB11YZtrRqY4EnQcLX5Rh373zbK4alC1FW7D7MBhL2gtcC17cTnr6DmfHZeS0s2rTHjUTMMHfG7gO8SSdw+g==

js-string-escape@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/js-string-escape/-/js-string-escape-1.0.1.tgz#e2625badbc0d67c7533e9edc1068c587ae4137ef"
integrity sha1-4mJbrbwNZ8dTPp7cEGjFh65BN+8=

"js-tokens@^3.0.0 || ^4.0.0", js-tokens@^4.0.0:
version "4.0.0"
resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-4.0.0.tgz#19203fb59991df98e3a287050d4647cdeaf32499"
Expand Down