CLI: make color output legible on dark backgrounds #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClusterShell's default colored output uses dark colors, which are difficult to read on dark background terminals. Using the light version of each color improves legibility on dark bacrounds, without affecting display on light backgrounds.
degremont
requested changes
Sep 7, 2017
Collaborator
degremont
left a comment
degremont
left a comment
There was a problem hiding this comment.
Could you fix the 2 typos in commit message?
ClusterShell's default colored output uses dark colors, which are difficult to read on dark background terminals. Using the light version of each color improves legibility on dark backgrounds, without affecting display on light backgrounds.
Contributor
Author
|
Aw, I worked hard on those typos! |
degremont
changed the title
degremont
approved these changes
Sep 14, 2017
Collaborator
|
closing/opening to trigger tests as this was proposed before travis CI support |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClusterShell's default colored output uses dark colors, which are difficult to read on dark background terminals. Using the light version of each color improves legibility on dark bacrounds, without affecting display on light backgrounds.