-
Notifications
You must be signed in to change notification settings - Fork 86
NodeUtils: allow YAML list to declare node groups #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rack5:
- 'example[200-205]' # some comment about example[200-205]
- 'example245'
- 'example300,example[401-406]'
griznog$ nodeset -f @racks:rack5
example[200-205,245,300,401-406]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patch. It looks good, could you also:
- Add a test for that in
tests/NodeSetGroupTest.py, at the end ofYAMLGroupLoaderTestclass - A tiny example in the doc in
doc/sphinx/config.rst
Could you also edit your commit message and make it looks similar to 9b3a239 by example, meaning:
- A title with a prefix :
NodeUtils: - A small title (less than 70 char):
allow YAML list to declare node groups - A blank line
- A sentence explaining the change more in detail
|
Thanks for the changes. They looks good! However, when I was talking about the commit message, I was really talking about the commit message of the unique commit you should have in this branch. |
If group is a list, ','.join to make a string before returning _list_node().
|
Clearly I'm lost with the git squash part of this, I don't understand why I wound up with the second merge commit? Lots of "first time doing X" for me in this process, thanks for being patient. |
thiell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks @griznog! Getting ready for your cluster of tractors? ;-)
We'll be able to squash the commits for you when merging, no worries.
|
Thanks @griznog , I managed the squash things. Thanks for your patch! |
I'm hoping to keep my squash in the garden :) |
Allow the use of YAML list syntax when defining node groups.