eh/filters: send rpctransactions in pending-subscription #2252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palango
reviewed
Feb 12, 2024
palango
reviewed
Feb 12, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2252 +/- ##
==========================================
+ Coverage 55.06% 55.77% +0.71%
==========================================
Files 684 684
Lines 114596 91952 -22644
==========================================
- Hits 63097 51287 -11810
+ Misses 47617 36783 -10834
Partials 3882 3882 ☔ View full report in Codecov by Sentry. |
palango
force-pushed
the
send-pending-rpc-transactions
branch
from
f0d7441 to
c86947d
Compare
|
@diwu1989 Thanks for the PR, I added another comment cleaning up some unnecessary parameter. |
palango
force-pushed
the
send-pending-rpc-transactions
branch
from
c86947d to
985a4b2
Compare
carterqw2
approved these changes
Feb 16, 2024
|
Coverage from tests in coverage: 49.9% of statements across all listed packagescoverage: 63.4% of statements in consensus/istanbul coverage: 42.7% of statements in consensus/istanbul/announce coverage: 55.8% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 61.6% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.2% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting ethereum/go-ethereum#26126 to Celo so that the pending subscription TX has consistent JSON.
This was fixed upstream by always using the
ethapi.NewRPCPendingTransactionfunction