Skip to content

Conversation

@hieronx
Copy link
Contributor

@hieronx hieronx commented Apr 11, 2025

No description provided.

@wischli wischli added the 💡 idea Represent an idea draft based on a conversation label Apr 15, 2025
@wischli wischli changed the title Add min subordination manager [Idea] Add min subordination manager Apr 15, 2025
@mustermeiszer mustermeiszer changed the title [Idea] Add min subordination manager Idea: Add min subordination manager Apr 16, 2025
@hieronx hieronx changed the title Idea: Add min subordination manager Idea: min subordination manager Apr 30, 2025
@hieronx hieronx changed the base branch from main to spearbit-fixreview May 28, 2025 07:09
Base automatically changed from spearbit-fixreview to main July 2, 2025 17:39
@github-actions
Copy link

github-actions bot commented Jul 3, 2025

Coverage after merging min-subordination into main will be

90.24%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/common
   BaseValuation.sol100%100%100%100%
   GasService.sol100%100%100%100%
   Gateway.sol100%100%100%100%
   Guardian.sol85.19%64.29%100%85.71%107, 112, 152, 152–153, 50–54, 90, 95
   MessageDispatcher.sol71.88%66.67%72%74.34%116, 123, 123, 123–124, 126, 139–140, 140, 140–141, 143, 289, 293, 293, 293–294, 296, 309, 313, 313, 313–314, 316, 325–326, 326, 326–327, 329, 334–335, 335, 335–336, 338, 343, 351, 351, 351–352, 356, 64–68
   MessageProcessor.sol68.24%41.07%100%83.91%101, 104, 109, 109–112, 112–115, 120, 123, 126, 129, 132, 141, 146, 149, 162, 173, 173, 173–175, 178, 178, 178–180, 182, 51–55, 69, 71, 74, 77, 77–79, 82, 85, 88, 90
   PoolEscrow.sol100%100%100%100%
   Root.sol98.48%91.67%100%100%23
   TokenRecoverer.sol84.62%50%100%88.89%24–25
src/common/adapters
   AxelarAdapter.sol90.91%83.33%100%92.59%45–46, 55–56
   MultiAdapter.sol100%100%100%100%
   WormholeAdapter.sol100%100%100%100%
src/common/factories
   PoolEscrowFactory.sol100%100%100%100%
src/common/libraries
   MessageLib.sol89.16%64.18%96.55%98.69%113–114, 119, 175, 192, 213, 237, 254, 277, 318, 348, 374, 400, 426, 455, 479, 505, 533, 559, 588, 614, 642, 667, 712, 743, 767
   MessageProofLib.sol88.89%50%100%100%14
   PricingLib.sol100%100%100%100%
   RequestCallbackMessageLib.sol88.64%50%100%100%106, 141, 38, 57, 77
   RequestMessageLib.sol88.89%50%100%100%37, 55, 72, 89
src/hooks
   FreezeOnly.sol5%0%11.11%5.13%100, 102, 107–108, 108, 108–109, 109, 109, 111–112, 114, 118–120, 122, 126–127, 135–136, 45, 50, 50, 50–51, 55, 62, 66, 71–72, 72, 74, 77–78, 78, 80, 83, 91–92, 94, 94, 94–97, 97, 97–99
   FullRestrictions.sol97.67%90%100%100%123, 147
   RedemptionRestrictions.sol51.72%25%63.64%58.93%107, 110, 110, 110–113, 113, 113–116, 118, 123–124, 124, 124–125, 125, 125, 127–128, 130, 134–136, 138, 142, 147–149, 53, 75, 77, 81, 83, 86, 88
src/hooks/libraries
   UpdateRestrictionMessageLib.sol89.29%50%100%100%40, 61, 82
src/hub
   Accounting.sol93.75%96%100%91.53%114–115, 118–119, 134, 137
   Holdings.sol97.20%85.71%100%100%105, 211, 82
   Hub.sol80.50%42.86%98%84.93%111, 203, 205–206, 217–218, 247–248, 259–260, 278, 282, 284, 291, 430–431, 434, 434–435, 453, 456, 456–457, 477, 494, 511, 538, 542, 572–573, 573, 573–574, 574, 574, 579, 584, 602, 612, 612, 612, 614, 628, 635–637, 68, 727, 79–80, 80–81, 81–82, 82–83, 83–84, 84–86
   HubHelpers.sol88.46%87.50%90%88.54%155–157, 163–165, 215, 239, 244–247, 54–55
   HubRegistry.sol93.51%79.17%100%100%104, 110, 116, 33, 44
   ShareClassManager.sol100%100%100%100%
src/managers
   MerkleProofManager.sol79.45%61.11%88.89%84.78%104, 111, 130–131, 131, 131, 133–134, 136–137, 40–41, 44, 54
   MinSubordinationRatio.sol0%0%0%0%28, 36–38, 40–42, 46–48, 52, 61–62, 64–65, 67–68, 70–71, 73–74, 76, 80–82, 84–85, 87–88, 88, 88
   OnOfframpManager.sol90.59%82.14%100%94%132, 52, 63, 67–68, 78, 84, 87
src/managers/decoders
   BaseDecoder.sol75%100%75%75%43–44
   CircleDecoder.sol0%100%0%0%11, 16, 20, 22
   VaultDecoder.sol0%100%0%0%10, 104, 110, 15–16, 22, 28, 34, 40, 46, 52, 58, 64, 69, 75, 80, 86, 9, 92, 98
src/misc
   Auth.sol100%100%100%100%
   ERC20.sol100%100%100%100%
   Escrow.sol56.25%33.33%100%66.67%15, 17, 21–22, 22, 22, 24
   IdentityValuation.sol100%100%100%100%
   Multicall.sol83.33%33.33%100%100%17, 17
   Recoverable.sol100%100%100%100%
   ReentrancyProtection.sol90%75%100%100%22
src/misc/libraries
   ArrayLib.sol95.83%75%100%100%26
   BitmapLib.sol100%100%100%100%
   BytesLib.sol90.09%54.17%100%100%109, 120, 131, 14, 142, 153, 16, 164, 175, 186, 87
   CastLib.sol95.12%66.67%100%100%31, 7
   EIP712Lib.sol100%100%100%100%
   MathLib.sol92.47%70.59%100%97.06%33–34, 43, 45, 47, 49, 51
   MerkleProofLib.sol100%100%100%100%
   SafeTransferLib.sol96.97%92.86%100%100%75
   SignatureLib.sol95.24%80%100%100%17
   StringLib.sol100%100%100%100%
   TransientArrayLib.sol100%100%100%100%
   TransientBytesLib.sol100%100%100%100%
   TransientStorageLib.sol100%100%100%100%
src/spoke
   BalanceSheet.sol99.45%96.55%100%100%59
   ContractUpdater.sol100%100%100%100%
   ShareToken.sol93.51%66.67%94.12%98.04%101, 113, 146, 33
   Spoke.sol87.37%73%89.74%93.13%124, 124–125, 125, 127, 154, 202, 210, 282, 294–297, 300–302, 302, 302, 304–306, 317, 330, 340–342,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💡 idea Represent an idea draft based on a conversation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants