-
Notifications
You must be signed in to change notification settings - Fork 311
Access extra.* like normal fields #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's obsolete
Codecov Report
@@ Coverage Diff @@
## develop #1046 +/- ##
===========================================
+ Coverage 75.57% 75.72% +0.14%
===========================================
Files 216 217 +1
Lines 9196 9310 +114
Branches 1231 1244 +13
===========================================
+ Hits 6950 7050 +100
- Misses 1957 1970 +13
- Partials 289 290 +1
|
ghost
commented
Aug 7, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better document this: old bots can still be used, the harmonization.conf must be changed!
add a intelmqctl check for this
added warnings in lib and ctl check
Got no feedback, so probably ok |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now set and get extra-fields just as all others #793 :
This is not limited to
extra.*
, it applies to anything field with typeJSONDict
It now behaves correctly with the hierarchical keyword see #791
A new harminization type is introduced, the
JSONDict
(like the formerJSON
type, can only hold dicts as JSON) andJSON
itself is not more relaxed (allows not only dicts, but any valid JSON). The typeJSON
is used for the fieldoutput
.For backwards compatibility, you can still set extra to a string holding a JSON, however I don't recommend it.
I did not yet deprecate anything (setting and getting extra as whole) because I think we need to discuss this better, also for other nested fields.