Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Jul 25, 2017

You can now set and get extra-fields just as all others #793 :

event['extra.foo'] = 'bla'
event['extra.foo'] # gives 'bar'

This is not limited to extra.*, it applies to anything field with type JSONDict

It now behaves correctly with the hierarchical keyword see #791

A new harminization type is introduced, the JSONDict (like the former JSON type, can only hold dicts as JSON) and JSON itself is not more relaxed (allows not only dicts, but any valid JSON). The type JSON is used for the field output.

For backwards compatibility, you can still set extra to a string holding a JSON, however I don't recommend it.

I did not yet deprecate anything (setting and getting extra as whole) because I think we need to discuss this better, also for other nested fields.

Sebastian Wagner added 3 commits July 25, 2017 15:16
@ghost ghost changed the title Dev extra Access extra.* like normal fields Jul 25, 2017
@codecov-io
Copy link

codecov-io commented Jul 25, 2017

Codecov Report

Merging #1046 into develop will increase coverage by 0.14%.
The diff coverage is 88.97%.

@@             Coverage Diff             @@
##           develop    #1046      +/-   ##
===========================================
+ Coverage    75.57%   75.72%   +0.14%     
===========================================
  Files          216      217       +1     
  Lines         9196     9310     +114     
  Branches      1231     1244      +13     
===========================================
+ Hits          6950     7050     +100     
- Misses        1957     1970      +13     
- Partials       289      290       +1
Impacted Files Coverage Δ
...s/bots/parsers/shadowserver/test_accessible_smb.py 100% <ø> (ø) ⬆️
...s/parsers/shadowserver/test_compromised_website.py 100% <ø> (ø) ⬆️
intelmq/bots/parsers/shadowserver/config.py 85.39% <ø> (ø) ⬆️
intelmq/tests/bots/outputs/mongodb/test_output.py 100% <ø> (ø) ⬆️
...elmq/tests/bots/parsers/shadowserver/test_xdmcp.py 100% <ø> (ø) ⬆️
...telmq/tests/bots/parsers/shadowserver/test_snmp.py 100% <ø> (ø) ⬆️
...sts/bots/parsers/shadowserver/test_drone_hadoop.py 100% <ø> (ø) ⬆️
...mq/tests/bots/parsers/shadowserver/test_chargen.py 100% <ø> (ø) ⬆️
...mq/tests/bots/parsers/dshield/test_parser_block.py 100% <ø> (ø) ⬆️
...q/tests/bots/parsers/anubisnetworks/test_parser.py 100% <ø> (ø) ⬆️
... and 23 more

Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better document this: old bots can still be used, the harmonization.conf must be changed!

add a intelmqctl check for this

@ghost ghost added this to the 1.1.0 milestone Aug 23, 2017
@ghost
Copy link
Author

ghost commented Aug 23, 2017

Got no feedback, so probably ok

@ghost ghost merged commit 9d0a6b8 into certtools:develop Aug 23, 2017
@ghost ghost deleted the dev-extra branch November 30, 2017 18:39
@ghost ghost mentioned this pull request Dec 12, 2017
7 tasks
@ghost ghost mentioned this pull request Apr 10, 2019
15 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant