chore:1.4.9-testnet #78
Conversation
WalkthroughThe Dockerfile was updated to change the download source for the cronos binary from the "v1.4.9" release to the "v1.4.9-testnet" release. The filename and URL were adjusted accordingly, while all other extraction and installation steps remain unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(1 hunks)
🧰 Additional context used
🪛 Checkov (3.2.334)
Dockerfile
[HIGH] 7-8: Ensure that certificate validation isn't disabled with wget
(CKV2_DOCKER_3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: guardrails/scan
| RUN mkdir -p /home/cronos/data && mkdir -p /home/cronos/config | ||
| RUN apt-get update -y && apt-get install wget curl procps net-tools jq lz4 -y | ||
| RUN cd /tmp && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.4.9/cronos_1.4.9_Linux_x86_64.tar.gz && tar -xvf cronos_1.4.9_Linux_x86_64.tar.gz \ | ||
| RUN cd /tmp && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.4.9/cronos_1.4.9-testnet_Linux_x86_64.tar.gz && tar -xvf cronos_1.4.9_Linux_x86_64.tar.gz \ |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Avoid --no-check-certificate unless absolutely necessary
Disabling TLS verification silences MITM-protection and triggers CVE scanners (CKV2_DOCKER_3).
If GitHub’s certificate problems are not expected, remove the flag; otherwise fetch the artifact with curl --proto '=https' --tlsv1.2 --location and pin the SHA256 to guarantee integrity.
🧰 Tools
🪛 Checkov (3.2.334)
[HIGH] 7-8: Ensure that certificate validation isn't disabled with wget
(CKV2_DOCKER_3)
🤖 Prompt for AI Agents
In Dockerfile at line 7, remove the wget option --no-check-certificate to avoid
disabling TLS verification. Instead, replace wget with curl using the flags
--proto '=https' --tlsv1.2 --location to securely fetch the file. Additionally,
add a step to verify the downloaded file's SHA256 checksum to ensure its
integrity before extraction.
| RUN cd /tmp && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.4.9/cronos_1.4.9-testnet_Linux_x86_64.tar.gz && tar -xvf cronos_1.4.9_Linux_x86_64.tar.gz \ | ||
| && rm cronos_1.4.9_Linux_x86_64.tar.gz && mv ./* /home/cronos/ | ||
| RUN chown -R cronos:cronos /home/cronos && chmod 1777 /tmp |
There was a problem hiding this comment.
Archive name mismatch will break the build
The file you now download is cronos_1.4.9-testnet_Linux_x86_64.tar.gz, yet the subsequent tar -xvf and rm commands still reference cronos_1.4.9_Linux_x86_64.tar.gz.
At build time the tar step will fail with “cannot open: No such file or directory”, aborting the image build.
-RUN cd /tmp && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.4.9/cronos_1.4.9-testnet_Linux_x86_64.tar.gz && tar -xvf cronos_1.4.9_Linux_x86_64.tar.gz \
- && rm cronos_1.4.9_Linux_x86_64.tar.gz && mv ./* /home/cronos/
+RUN cd /tmp \
+ && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.4.9-testnet/cronos_1.4.9-testnet_Linux_x86_64.tar.gz \
+ && tar -xvf cronos_1.4.9-testnet_Linux_x86_64.tar.gz \
+ && rm cronos_1.4.9-testnet_Linux_x86_64.tar.gz \
+ && mv ./* /home/cronos/(Notice I also fixed the release path to /v1.4.9-testnet/; the current one still points to /v1.4.9/.)
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| RUN cd /tmp && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.4.9/cronos_1.4.9-testnet_Linux_x86_64.tar.gz && tar -xvf cronos_1.4.9_Linux_x86_64.tar.gz \ | |
| && rm cronos_1.4.9_Linux_x86_64.tar.gz && mv ./* /home/cronos/ | |
| RUN chown -R cronos:cronos /home/cronos && chmod 1777 /tmp | |
| RUN cd /tmp \ | |
| && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.4.9-testnet/cronos_1.4.9-testnet_Linux_x86_64.tar.gz \ | |
| && tar -xvf cronos_1.4.9-testnet_Linux_x86_64.tar.gz \ | |
| && rm cronos_1.4.9-testnet_Linux_x86_64.tar.gz \ | |
| && mv ./* /home/cronos/ | |
| RUN chown -R cronos:cronos /home/cronos && chmod 1777 /tmp |
🧰 Tools
🪛 Checkov (3.2.334)
[HIGH] 7-8: Ensure that certificate validation isn't disabled with wget
(CKV2_DOCKER_3)
🤖 Prompt for AI Agents
In Dockerfile lines 7 to 9, the downloaded archive filename
cronos_1.4.9-testnet_Linux_x86_64.tar.gz does not match the filename used in the
tar and rm commands, causing build failure. Update the tar and rm commands to
reference cronos_1.4.9-testnet_Linux_x86_64.tar.gz instead of
cronos_1.4.9_Linux_x86_64.tar.gz. Also, ensure the download URL path matches the
testnet version /v1.4.9-testnet/ as corrected.
Summary by CodeRabbit