Skip to content

Fix #4368: In unicode-mode RegExp, explicitly disallow invalid escapes. #4637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2018
Merged

Fix #4368: In unicode-mode RegExp, explicitly disallow invalid escapes. #4637

merged 1 commit into from
Feb 2, 2018

Conversation

@dilijev
Copy link
Contributor

@dilijev dilijev commented Feb 2, 2018 •
edited
Loading

Fixes #4368

@dilijev dilijev self-assigned this Feb 2, 2018
@dilijev dilijev changed the base branch from master to release/1.8 February 2, 2018 03:15
boingoing
boingoing approved these changes Feb 2, 2018
View reviewed changes
Copy link
Contributor

@boingoing boingoing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chakrabot chakrabot merged commit 8933017 into chakra-core:release/1.8 Feb 2, 2018
chakrabot pushed a commit that referenced this pull request Feb 2, 2018
@dilijev
[MERGE #4637 @dilijev] Fix #4368: In unicode-mode RegExp, explicitly …
006593e 
…disallow invalid escapes.

Merge pull request #4637 from dilijev:re-escape-forbidden

Fixes #4368
@dilijev dilijev deleted the re-escape-forbidden branch February 2, 2018 22:44
chakrabot pushed a commit that referenced this pull request Feb 2, 2018
@dilijev
[1.8>1.9] [MERGE #4637 @dilijev] Fix #4368: In unicode-mode RegExp, e…
5c0bed5 
…xplicitly disallow invalid escapes.

Merge pull request #4637 from dilijev:re-escape-forbidden

Fixes #4368
chakrabot pushed a commit that referenced this pull request Feb 2, 2018
@dilijev
[1.9>master] [1.8>1.9] [MERGE #4637 @dilijev] Fix #4368: In unicode-m…
eac97b9 
…ode RegExp, explicitly disallow invalid escapes.

Merge pull request #4637 from dilijev:re-escape-forbidden

Fixes #4368
dilijev added a commit to dilijev/ChakraCore that referenced this pull request Feb 6, 2018
@dilijev
OS#15775563: Fix-up previous change. Explicitly allow identity escapes.
2d67b9a 
See chakra-core#4637: Fix chakra-core#4368: In unicode-mode RegExp, explicitly disallow invalid escapes.

Fixes OS#15775563
dilijev added a commit to dilijev/ChakraCore that referenced this pull request Feb 6, 2018
@dilijev
OS#15775563: Fix-up previous change. Explicitly allow identity escapes.
dfb7277 
See chakra-core#4637: Fix chakra-core#4368: In unicode-mode RegExp, explicitly disallow invalid escapes.

Fixes OS#15775563
@dilijev dilijev mentioned this pull request Feb 6, 2018
Merged
chakrabot pushed a commit that referenced this pull request Feb 6, 2018
@dilijev
[MERGE #4644 @dilijev] OS#15775563: Fix-up previous change. Explicitl…
b274e7b 
…y allow RegExp identity escapes.

Merge pull request #4644 from dilijev:fix_unicode_forbidden_escapes

See #4637: Fix #4368: In unicode-mode RegExp, explicitly disallow invalid escapes.

Fixes OS#15775563
chakrabot pushed a commit that referenced this pull request Feb 6, 2018
@dilijev
[1.8>1.9] [MERGE #4644 @dilijev] OS#15775563: Fix-up previous change.…
a92d32a 
… Explicitly allow RegExp identity escapes.

Merge pull request #4644 from dilijev:fix_unicode_forbidden_escapes

See #4637: Fix #4368: In unicode-mode RegExp, explicitly disallow invalid escapes.

Fixes OS#15775563
chakrabot pushed a commit that referenced this pull request Feb 6, 2018
@dilijev
[1.9>master] [1.8>1.9] [MERGE #4644 @dilijev] OS#15775563: Fix-up pre…
bf232c9 
…vious change. Explicitly allow RegExp identity escapes.

Merge pull request #4644 from dilijev:fix_unicode_forbidden_escapes

See #4637: Fix #4368: In unicode-mode RegExp, explicitly disallow invalid escapes.

Fixes OS#15775563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sethbrenith sethbrenith sethbrenith approved these changes

@boingoing boingoing boingoing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dilijev dilijev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dilijev @sethbrenith @boingoing @chakrabot