Set U_USING_ICU_NAMESPACE to 0 by default
#4952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ICU61 updated the value of `U_USING_ICU_NAMESPACE` to 0 by default. In order to maintain compatibility this change updates our ICU includes to match and adds the `icu::` namespace explicitly when needed. Refs: nodejs/node#18667 Refs: https://ssl.icu-project.org/trac/ticket/13460
|
Ported the change and kicked off a node CI: https://ci.nodejs.org/job/chakracore-test/298/ |
digitalinfinity
approved these changes
Apr 9, 2018
|
@dotnet-bot test OSX please |
|
@dotnet-bot test OSX static_osx_osx_debug please |
|
@dotnet-bot test OSX static_osx_osx_test please |
|
Thanks @digitalinfinity! |
chakrabot
pushed a commit
that referenced
this pull request
Apr 9, 2018
Merge pull request #4952 from kfarnung:icu61 ICU61 updated the value of `U_USING_ICU_NAMESPACE` to 0 by default. In order to maintain compatibility this change updates our ICU includes to match and adds the `icu::` namespace explicitly when needed. Refs: nodejs/node#18667 Refs: https://ssl.icu-project.org/trac/ticket/13460
chakrabot
pushed a commit
that referenced
this pull request
Apr 9, 2018
… by default Merge pull request #4952 from kfarnung:icu61 ICU61 updated the value of `U_USING_ICU_NAMESPACE` to 0 by default. In order to maintain compatibility this change updates our ICU includes to match and adds the `icu::` namespace explicitly when needed. Refs: nodejs/node#18667 Refs: https://ssl.icu-project.org/trac/ticket/13460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICU61 updated the value of
U_USING_ICU_NAMESPACEto 0 by default. Inorder to maintain compatibility this change updates our ICU includes to
match and adds the
icu::namespace explicitly when needed.Refs: nodejs/node#18667
Refs: https://ssl.icu-project.org/trac/ticket/13460