Relaxing an assert in TinyDictionary #5518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible and ok for the data to contain `FF`. The assert that we have in `TryGetValue` could get triggered if an unsuccessfull lookup goes through this value. The added code in the test does that.
pleath
approved these changes
Jul 24, 2018
chakrabot
pushed a commit
that referenced
this pull request
Jul 24, 2018
Merge pull request #5518 from VSadov:tiny It is possible and ok for the `data` part of the dictionary to contain `FF`. The assert that we have in `TryGetValue` could get triggered if an unsuccessfull lookup goes through such value. The added test code does that, as an example.
|
Thanks!! |
chakrabot
pushed a commit
that referenced
this pull request
Jul 24, 2018
Merge pull request #5518 from VSadov:tiny It is possible and ok for the `data` part of the dictionary to contain `FF`. The assert that we have in `TryGetValue` could get triggered if an unsuccessfull lookup goes through such value. The added test code does that, as an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible and ok for the
datapart of the dictionary to containFF.The assert that we have in
TryGetValuecould get triggered if an unsuccessfull lookup goes through such value. The added test code does that, as an example.