MSFT:18210422 Remove the dummy field in NoResizeLock that adds 8 bytes to all BaseDictionary instances using NoResizeLock. #5539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethbrenith
approved these changes
Jul 26, 2018
…s to all BaseDictionary instances using NoResizeLock.
chakrabot
pushed a commit
that referenced
this pull request
Jul 27, 2018
…sizeLock that adds 8 bytes to all BaseDictionary instances using NoResizeLock. Merge pull request #5539 from atulkatti:Bug18210422.RevertBaseDictionarySizeChange.1 This was added only to help with prefast analysis. I will need to add some prefast ignore statements after looking at the failures.
chakrabot
pushed a commit
that referenced
this pull request
Jul 27, 2018
… field in NoResizeLock that adds 8 bytes to all BaseDictionary instances using NoResizeLock. Merge pull request #5539 from atulkatti:Bug18210422.RevertBaseDictionarySizeChange.1 This was added only to help with prefast analysis. I will need to add some prefast ignore statements after looking at the failures.
|
I think that this change has caused some prefast failures, at least I saw arm complain at https://ci2.dot.net/job/Microsoft_ChakraCore/job/release_1.10/job/arm_release_prtest/352/consoleFull#644395203ac1851af-571d-472f-b664-6657b078a5dd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added only to help with prefast analysis. I will need to add some prefast ignore statements after looking at the failures.