Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
palinternal.h
defines a fallback for themin
andmax
macros in case the compiler does not:ChakraCore/pal/src/include/pal/palinternal.h
Lines 689 to 696 in 36becec
finite.cpp
importspalinternal.h
before<math>
so we end up with two conflicting definitions ofmin
andmax
:ChakraCore/pal/src/cruntime/finite.cpp
Lines 22 to 24 in 36becec
@rhuanjl This is the first in a stack of PRs that will hopefully fix MacOS ci.
Until then, MacOS builds will fail...