Skip to content

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Aug 12, 2019

No description provided.

Copy link
Contributor

@Jikstra Jikstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This makes things a lot easier. In another pr we can move the Vec to dc_array_t conversion into the ffi.

@link2xt
Copy link
Collaborator Author

link2xt commented Aug 12, 2019

@Jikstra already did that, need to rebase and force-push into #334 once this one is merged

@link2xt
Copy link
Collaborator Author

link2xt commented Aug 12, 2019

I also think about converting Vec<uintptr_t> into Vec<u32>, but for that we need to deprecate dc_array_add_ptr.

@Jikstra
Copy link
Contributor

Jikstra commented Aug 12, 2019

@link2xt can you come online on irc? Would like to streamline those 3 prs around the get_chat_contacts methods as it would fix a panic in -desktop.

EDIT: Do you have write permissions to this repo? I think it's easier to checkout branches/prs if it's all on the same repo.

@Jikstra Jikstra merged commit 39fbff5 into chatmail:master Aug 12, 2019
@link2xt link2xt deleted the dc_array_t-new branch August 12, 2019 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants