-
-
Notifications
You must be signed in to change notification settings - Fork 108
test: Add unique offsets to ids generated by TestContext
to increase test correctness
#7297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add unique offsets to ids generated by TestContext
to increase test correctness
#7297
Conversation
Seems my approach of just dividing the random number does not work, this approach is not compatible with the golden tests:
we could add an id to the named accounts, as this offset needs to be unique account per per test, but not unique across all tests. |
TestContext
to increaseTestContext
to increase test correctness
UPDATE_GOLDEN_TESTS=1 cargo nextest run |
b85ffa1
to
6aa4739
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🎉!
correctness of tests. The ids that get offsets are: contact ids chat ids message ids webxdc status update ids
`receive_imf::receive_imf_tests::test_delayed_removal_is_ignored`
`receive_imf::receive_imf_tests::test_older_message_from_2nd_device`
`receive_imf::receive_imf_tests::test_two_group_securejoins`
`tests::verified_chats::test_verified_chat_editor_reordering`
fb7c93c
to
1c77c06
Compare
and fix the mistakes in tests that get discovered by this.
closes #6799