Skip to content

test: Add unique offsets to ids generated by TestContext to increase test correctness #7297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Oct 19, 2025
Merged

test: Add unique offsets to ids generated by TestContext to increase test correctness #7297

merged 23 commits into from
Oct 19, 2025
+137 −60

Conversation

Simon-Laux
Copy link
Contributor

@Simon-Laux Simon-Laux commented Oct 11, 2025 •
edited
Loading

and fix the mistakes in tests that get discovered by this.

  • add tests for setting the offset
  • fix the tests that were discovered by this
  • find a solution for the golden test problem (golden tests expect the offset to be deterministic, currently it is derived from the account id which is random)

closes #6799

@Simon-Laux
Copy link
Contributor Author

Seems my approach of just dividing the random number does not work, this approach is not compatible with the golden tests:

    thread 'tests::verified_chats::test_verified_chat_editor_reordering' panicked at src/test_utils.rs:977:13:
    assertion failed: `(left == right)`: To update the expected value, run `UPDATE_GOLDEN_TESTS=1 cargo test`

    Diff < left / right > :
    <Group#Chat#1979039380: Group [3 member(s)] 🛡️
    >Group#Chat#11: Group [3 member(s)] 🛡️

we could add an id to the named accounts, as this offset needs to be unique account per per test, but not unique across all tests.

@Simon-Laux Simon-Laux self-assigned this Oct 11, 2025
@Simon-Laux Simon-Laux changed the title test: Add unique offsets to ids generated by TestContext to increase test: Add unique offsets to ids generated by TestContext to increase test correctness Oct 11, 2025
@Hocuri
Copy link
Collaborator

Hocuri commented Oct 13, 2025 •
edited
Loading

UPDATE_GOLDEN_TESTS=1 cargo nextest run

@Simon-Laux Simon-Laux force-pushed the simon/i6799-add-offset-to-testaccount-ids-to-make-tests-more-reliable branch from b85ffa1 to 6aa4739 Compare October 16, 2025 20:23
@Simon-Laux Simon-Laux marked this pull request as ready for review October 18, 2025 16:05
Hocuri
Hocuri approved these changes Oct 18, 2025
View reviewed changes
Copy link
Collaborator

@Hocuri Hocuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉!

link2xt
link2xt approved these changes Oct 18, 2025
View reviewed changes
@Simon-Laux Simon-Laux requested review from Hocuri and link2xt October 19, 2025 15:51
@Simon-Laux
test: Add unique offsets to ids generated by TestContext to increase
c401828 
correctness of tests.

The ids that get offsets are: contact ids chat ids message ids webxdc
status update ids
@Simon-Laux
fix test_forward_from_saved_to_saved and test_broadcast
59757b1
@Simon-Laux
static offsets in accounts created in TestContextManager
aee5994
@Simon-Laux
add offsets to TestContext::new_(alice,bob,fiona)
094db60
@Simon-Laux
exclude msgs_status_updates from the offsets for now.
a0f967d
@Simon-Laux
fix chat::chat_tests::test_info_contact_id
64b9e07
@Simon-Laux
fix chat::chat_tests::test_msg_with_implicit_member_removed
627020c
@Simon-Laux
update golden test chat::chat_tests::test_parallel_member_remove
bfc4ff3
@Simon-Laux
fix test peer_channels::tests::test_can_communicate
ceac399
@Simon-Laux
fix test receive_imf::receive_imf_tests::test_accept_outgoing
89355a5
@Simon-Laux
update golden test
2d764df 
`receive_imf::receive_imf_tests::test_delayed_removal_is_ignored`
@Simon-Laux
update golden test
9585b22 
`receive_imf::receive_imf_tests::test_older_message_from_2nd_device`
@Simon-Laux
update golden test
69f93e8 
`receive_imf::receive_imf_tests::test_two_group_securejoins`
@Simon-Laux
fix test
4a8391d 
`sql::migrations::migrations_tests::test_key_contacts_migration_email2`
@Simon-Laux
update golden test tests::verified_chats::test_old_message_5
c5490da
@Simon-Laux
update golden test tests::verified_chats::test_outgoing_encrypted_msg
b7a7fdf
@Simon-Laux
update golden test tests::verified_chats::test_outgoing_mua_msg
2f1d170
@Simon-Laux
update golden test
b38b097 
`tests::verified_chats::test_verified_chat_editor_reordering`
@Simon-Laux
improve offset test
672e8ea
@Simon-Laux
re-add white spaces that were removed by autoformatting.
62504a4
@Simon-Laux Simon-Laux force-pushed the simon/i6799-add-offset-to-testaccount-ids-to-make-tests-more-reliable branch from fb7c93c to 1c77c06 Compare October 19, 2025 16:09
@Simon-Laux Simon-Laux mentioned this pull request Oct 19, 2025
Merged
@Simon-Laux Simon-Laux merged commit 59fac54 into main Oct 19, 2025
30 checks passed
@Simon-Laux Simon-Laux deleted the simon/i6799-add-offset-to-testaccount-ids-to-make-tests-more-reliable branch October 19, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hocuri Hocuri Awaiting requested review from Hocuri

@link2xt link2xt Awaiting requested review from link2xt

Assignees

@Simon-Laux Simon-Laux

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Offset row IDs in test accounts

3 participants

@Simon-Laux @Hocuri @link2xt