Skip to content

Add has_error and error_message methods #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 8, 2024
Merged

Add has_error and error_message methods #105

merged 7 commits into from
Jan 8, 2024

Conversation

nmreadelf
Copy link
Collaborator

add has_error and error_message methods

@nmreadelf nmreadelf force-pushed the feat/add-has_error-and-error_message branch from 814defc to 05019b9 Compare September 3, 2023 14:53
@nmreadelf nmreadelf requested a review from auxten September 3, 2023 14:57
auxten
auxten requested changes Sep 4, 2023
View reviewed changes
@nmreadelf nmreadelf force-pushed the feat/add-has_error-and-error_message branch 2 times, most recently from e1cddbc to a6b6f11 Compare September 4, 2023 08:41
@nmreadelf nmreadelf requested a review from auxten September 4, 2023 09:44
@ruslandoga ruslandoga mentioned this pull request Sep 11, 2023
Open
@Dennitz Dennitz mentioned this pull request Sep 11, 2023
Closed
@CLAassistant
Copy link

CLAassistant commented Dec 3, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@auxten auxten mentioned this pull request Dec 12, 2023
Closed
@auxten
Copy link
Member

auxten commented Jan 5, 2024

@nmreadelf Would you please rebase this patch to the current main branch?

@nmreadelf nmreadelf closed this Jan 6, 2024
@nmreadelf nmreadelf reopened this Jan 6, 2024
@nmreadelf nmreadelf force-pushed the feat/add-has_error-and-error_message branch 2 times, most recently from a6b6f11 to 7c2cb34 Compare January 6, 2024 02:27
@nmreadelf nmreadelf marked this pull request as draft January 6, 2024 02:32
@auxten auxten changed the title add has_error and error_message methods Add has_error and error_message methods Jan 6, 2024
@nmreadelf nmreadelf marked this pull request as ready for review January 6, 2024 04:41
auxten
auxten requested changes Jan 7, 2024
View reviewed changes
Copy link
Member

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Still need some improvements.

@nmreadelf nmreadelf marked this pull request as draft January 8, 2024 04:28
@nmreadelf nmreadelf force-pushed the feat/add-has_error-and-error_message branch from 7312182 to 903a173 Compare January 8, 2024 04:31
@nmreadelf nmreadelf marked this pull request as ready for review January 8, 2024 04:31
@nmreadelf nmreadelf requested a review from auxten January 8, 2024 04:31
auxten
auxten requested changes Jan 8, 2024
View reviewed changes
@auxten auxten merged commit a99fcbc into main Jan 8, 2024
This was referenced Mar 11, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auxten auxten auxten approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nmreadelf @CLAassistant @auxten