Bug fixes and modest extensions #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that occur before other declarations.
of functions doesn't make sense.
* Initial version of the checked-c conversion tool. Current features: - Processes single C files or multiple C files (up to whole programs) - Infers "ptr-ness" for local variables used in those programs. - Re-write many source files - Supports many aspects of the C grammar - Contains unit tests Current weaknesses: - Macro support is limited - Casting support is limited, needs structural type equality checks - No inherent support for standard library functions. - Doesn't honor existing checked C types
that occur before other declarations.
of functions doesn't make sense.
sometimes they even do something.
ptr<int> then that would mean 'a' would too, since the assignment copies the constraints. However, 'a' is used with arithmetic, so there doesn't seem to be a logical way that 'd' could be used as a ptr without a cast.
- typedefs complicate re-writing. Adopting a conservative strategy for now. - macros that define functions complicate identification of constraint variables. Adopting a conservative strategy for now.
Conflicts: tools/checked-c-convert/CheckedCConvert.cpp tools/checked-c-convert/ConstraintBuilder.cpp tools/checked-c-convert/ProgramInfo.cpp tools/checked-c-convert/ProgramInfo.h
| // so don't. | ||
| SourceRange SR = UD->getReturnTypeSourceRange(); | ||
| if(SR.isValid()) | ||
| if(SR.isValid() && (R.getRangeSize(SR) != -1)) |
There was a problem hiding this comment.
Nit: need a space after the 'if'
|
Generally looks good - I've pointed out some minor nits in the code. The PersistentSourceLoc file needs more comments describing what it is doing. Please clarify that the source location used for comparisons is the original textual location, not the expanded source location. You might want a helper function for validating that a range can be rewritten. Currently, you are checking that a range is valid and that getRangeSize(...) != -1. The test that getRangeSize(...) != -1 is idiomatic, so using a helper function would make the code clearer to read. |
|
I think I've addressed the code review feedback. |
|
LGTM. |
dopelsunce
pushed a commit
to dopelsunce/checkedc-clang
that referenced
this pull request
Sep 28, 2020
- Clarify that the checked property of an array declarator is only propagated to nested array declarators. It is not propagated to typedef bodies. - It is an error if there is a mismatch in checked properties between an array type and an element type that is an array type. - Improve the organization and wording of the text for checked multi-dimensional arrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many changes to deal with running on "real" code: