Issue #17487: add pluginManagement for rewrite-maven-plugin
#17948
Conversation
Pankraz76
force-pushed
the
fix-maven-pr
branch
from
b86521a to
dca97b6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Pankraz76
force-pushed
the
fix-maven-pr
branch
2 times, most recently
from
d46dd76 to
6a156be
Compare
|
please consider this dev experience increment. Using IDE on a simple way helps to integrate this faster. 
|
Pankraz76
force-pushed
the
fix-maven-pr
branch
from
6a156be to
f54454c
Compare
|
Please explain in PR description in words what is benefits of this update |
Pankraz76
force-pushed
the
fix-maven-pr
branch
from
f54454c to
dfd601b
Compare
updated, please give me critics. |
Pankraz76
force-pushed
the
fix-maven-pr
branch
3 times, most recently
from
6e5b707 to
4ad7d7d
Compare
Pankraz76
force-pushed
the
fix-maven-pr
branch
2 times, most recently
from
be48393 to
bb5ec99
Compare
Pankraz76
force-pushed
the
fix-maven-pr
branch
from
bb5ec99 to
e3f5ea6
Compare
|
why so many ci issues ? will this be gone after merge? its just cosmetic and moved some stuff. whats going on here? |
Weird.... |
Pankraz76
force-pushed
the
fix-maven-pr
branch
5 times, most recently
from
f7787e9 to
5b47c94
Compare
Pankraz76
force-pushed
the
fix-maven-pr
branch
3 times, most recently
from
6764927 to
761242e
Compare
stability first premis: |
Pankraz76
changed the title
AutoFixesrewrite-maven-plugin
|
lets split the concerns: |
This comment was marked as resolved.
This comment was marked as resolved.
Pankraz76
force-pushed
the
fix-maven-pr
branch
2 times, most recently
from
58a14c5 to
c74d827
Compare
Pankraz76
changed the title
rewrite-maven-pluginrewrite-maven-plugin
| <dependency> | ||
| <groupId>com.puppycrawl.tools</groupId> | ||
| <artifactId>checkstyle-openrewrite-recipes</artifactId> | ||
| <version>${checkstyle.openrewrite.version}</version> |
There was a problem hiding this comment.
again its a big mystery, why we can not inline this.
Pankraz76
force-pushed
the
fix-maven-pr
branch
from
c74d827 to
5d1fb7e
Compare
|
Please update PR description to clearly describe reason/benefits on moving from build to pluginManagement . All other wording , should be removed |
|
updated. |
|
You moved plugin from profile to Please update your PR description to explain correctly that you do . |
2 participants
Issue #17487: add pluginManagement for
rewrite-maven-pluginThe
rewrite-maven-pluginis not placed under thepluginManagementsection because it needs to be directly available for execution from the command line and IDE without requiring inheritance from a parent POM.When defined only in
pluginManagement, the plugin configuration is not automatically applied — it must be explicitly declared in each module’s build section. This would add unnecessary duplication and complexity for developers who need to run rewrite tasks locally.Keeping it in the
buildsection ensures that the plugin can be executed consistently in all environments while maintaining compatibility with existing project profiles such ascheckstyle-autofix.