Support multiple configuration files with the --config flag #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brocaar
added a commit
that referenced
this pull request
Jan 30, 2023
This regression was introduced by #199. cfgFiles does point to a slice, but it was not checked if the slice was empty or not. Therefore, no configuration file was read if the -c parameter was not used. Closes chirpstack/chirpstack-docker#74 and chirpstack/chirpstack-docker#75.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to start the Gateway Bridge with multiple --config arguments (or -c) to provide multiple configuration files.
The files are concatenated and then parsed as before.
The set of files must be consistent (e.g. each toml section only once between the files)
The concentratord has a similar behavior.