Skip to content

Conversation

@chrisw-dev
Copy link
Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@chrisw-dev chrisw-dev requested a review from Copilot October 12, 2025 21:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the JWT ID token generation to include a configurable name claim alongside the existing configurable email claim. The changes allow users to specify custom user names in the token configuration that will be included in generated ID tokens.

  • Modified JWT generation functions to accept and include a name parameter
  • Updated OAuth providers and token handlers to extract name from configuration
  • Added comprehensive test coverage for various configuration scenarios

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/jwt/jwt.go Modified GenerateIDToken function to accept and include name parameter
internal/jwt/jwt_test.go Updated tests to include name parameter in JWT generation calls
internal/handlers/token.go Enhanced token handler to extract name from configuration
pkg/oauth/google.go Modified Google provider to support configurable name with fallback
pkg/oauth/google_test.go Added comprehensive test suite for token configuration scenarios

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@chrisw-dev chrisw-dev merged commit 0b26d7f into main Oct 12, 2025
1 check passed
@chrisw-dev chrisw-dev deleted the add-name-to-id-token-claims branch October 12, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants