fix(error): Include -- in more cases #5356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by rust-lang/cargo#12494. Part of this is that our "did you mean" does prefix checks so it can be overly aggressive in providing suggestions. To avoid providing needless suggestions I limited this change to `last` / `trailing_var_arg` as those convey that `--` is more likely a valid suggestion.
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Feb 16, 2024
fix(test): Suggest `--` for libtest arguments We already do this so long as the argument doesn't look like a `cargo test` argument (e.g. `--show-output`) but `--ignored` looks like `--ignore-rust-version` do the the suggestion algorithms prefix checks. Before ``` error: unexpected argument '--ignored' found tip: a similar argument exists: '--ignore-rust-version' Usage: cargo test --ignore-rust-version [TESTNAME] [-- [ARGS]...] For more information, try '--help'. ``` After ``` error: unexpected argument '--ignored' found tip: a similar argument exists: '--ignore-rust-version' tip: to pass '--ignored' as a value, use '-- --ignored' Usage: cargo test --ignore-rust-version [TESTNAME] [-- [ARGS]...] For more information, try '--help'. ``` This was fixed in clap-rs/clap#5356 and we just need to update to take advantage of it. Fixes #12494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by rust-lang/cargo#12494.
Part of this is that our "did you mean" does prefix checks so it can be
overly aggressive in providing suggestions.
To avoid providing needless suggestions I limited this change to
last/
trailing_var_argas those convey that--is more likely a validsuggestion.