virtio-pci: use 2 32-bit writes for 64-bit fields #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per virtio spec 4.1.3.1 [1]: > For device configuration access, the driver MUST use 8-bit wide > accesses for 8-bit wide fields, 16-bit wide and aligned accesses for > 16-bit wide fields and 32-bit wide and aligned accesses for 32-bit > and 64-bit wide fields. This patch makes the virtio-pci driver sets 64-bit addresses with 2 32-bit writes to align with the spec. [1] https://docs.oasis-open.org/virtio/virtio/v1.2/csd01/virtio-v1.2-csd01.html#x1-1220001 Signed-off-by: Changyuan Lyu <[email protected]>
retrage
approved these changes
Dec 27, 2023
Contributor
retrage
left a comment
retrage
left a comment
There was a problem hiding this comment.
Thank you for the fix. It looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per virtio spec 4.1.3.1 [1]:
This patch makes the virtio-pci driver sets 64-bit addresses with 2 32-bit writes to align with the spec.
[1] https://docs.oasis-open.org/virtio/virtio/v1.2/csd01/virtio-v1.2-csd01.html#x1-1220001